Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-land "update the repo references for package:file (#55906)" #55935

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

re-land "update the repo references for package:file (#55906)" #55935

wants to merge 2 commits into from
+2 −6

Conversation

devoncarew
Copy link
Member

This is a re-land of the reverted PR, #55916 (it depended on a dart roll that was reverted, and has subsequently been re-landed).

From the original PR:

The SoT repository for package:file has changed from google/file.dart to dart-lang/tools; this PR updates the DEPS file and the hard-coded paths in the two pubspec.yaml files (see dart-lang/tools#674).

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Oct 17, 2024
zanderso
zanderso requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should wait until the internal roll succeeds since we may need to roll back again.

@devoncarew
Copy link
Member Author

This should wait until the internal roll succeeds since we may need to roll back again.

Gotcha - I'll hold off on landing this for a bit.

zanderso
zanderso approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devoncarew @zanderso