[Impeller] simpler labels for render target textures and cmd buffers. #55936
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| @@ -351,10 +349,7 @@ RenderTarget RenderTargetAllocator::CreateOffscreenMSAA( | |||
| return {}; | |||
| } | |||
| } | |||
| #ifdef IMPELLER_DEBUG | |||
There was a problem hiding this comment.
I removed this IFDEFS because the texture setlabel implemenations have the ifdef and we're not string formatting here anymore.
jonahwilliams
added
the
autosubmit
…157147) flutter/engine@0bb6b1f...a9bd470 2024-10-18 [email protected] [Impeller] simpler labels for render target textures and cmd buffers. (flutter/engine#55936) 2024-10-18 [email protected] [Impeller] use render pass to transition attachments to eGeneral instead of barriers. (flutter/engine#55930) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Avoid Sprintf'ing labels for textures/cmd buffers/render passes. For the render target textures, defer combined label construction until we know the label will be used.