Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emulator definitions version to latest available from chrome infra #56313

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Nov 1, 2024

Update to the latest definitions of emulator configurations.
Specifically to past https://crrev.com/c/5908894 which added gpu_mode: "swangle_indirect" to the api 35 proto. This should help with emulator stability on versions past android 13.
Related to b/371020223
Research notes / my findings for how this system works at go/flutter-android-ci-emulator

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@reidbaker reidbaker requested review from matanlurey and a team November 1, 2024 18:59
Copy link
Contributor

auto-submit bot commented Nov 1, 2024

auto label is removed for flutter/engine/56313, due to - The status or check suite Linux linux_android_emulator_tests_34 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2024
@reidbaker reidbaker marked this pull request as draft November 1, 2024 19:34
@reidbaker
Copy link
Contributor Author

Requires bot configuration change

@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants