Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opengles golden tests on linux #56364

Closed
wants to merge 8 commits into from
Closed

opengles golden tests on linux #56364

wants to merge 8 commits into from
+426 −289

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Nov 4, 2024 •
edited
Loading

issue: flutter/flutter#158215

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke mentioned this pull request Nov 5, 2024
Open
@gaaclarke
Copy link
Member Author

I'm abandoning this effort. I've noted why in flutter/flutter#158215 (comment)

@gaaclarke gaaclarke closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
e: impeller
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gaaclarke