Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Supress deprecated_member_use lint #982

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Conversation

LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Jul 20, 2023

Description

Addresses #981. There's code that's scaling non-text content using text scale factor so I'm not sure what the best way to migrate those code is.

Tests

Please describe the tests that you added or updated to verify your changes.

Issues

Fixes #


Note: Please find the development and releasing instructions at https://github.com/flutter/gallery#development

@LongCatIsLooong LongCatIsLooong force-pushed the supress-deprecation-warning branch from e11ee79 to 1b788da Compare July 20, 2023 18:12
@LongCatIsLooong LongCatIsLooong force-pushed the supress-deprecation-warning branch from 1b788da to 08b9642 Compare July 20, 2023 19:50
@LongCatIsLooong
Copy link
Contributor Author

Hi @guidezpl do you by chance know why the golden tests are failing? This isn't supposed to change the UI at all.

@guidezpl
Copy link
Member

Since the gallery builds against Flutter master, it often happens that they have to be updated due to upstream changes

@LongCatIsLooong LongCatIsLooong force-pushed the supress-deprecation-warning branch from 5a499e9 to 4ef8ab8 Compare July 21, 2023 07:55
@LongCatIsLooong LongCatIsLooong force-pushed the supress-deprecation-warning branch from cc569fc to a96c5db Compare July 21, 2023 08:35
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please create an issue for replacing these with something appropriate?

@LongCatIsLooong
Copy link
Contributor Author

@guidezpl created #983 . Thanks for the help!

@guidezpl guidezpl merged commit 873b705 into main Jul 21, 2023
@guidezpl guidezpl deleted the supress-deprecation-warning branch July 21, 2023 09:47
@guidezpl guidezpl linked an issue Jul 21, 2023 that may be closed by this pull request
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gallery is using deprecated things
2 participants