Skip to content

Commit

Permalink
Roll to 9d5ede0f5, disabling impeller for google_maps_flutter_android (
Browse files Browse the repository at this point in the history
…#7294)

Attempts to unblock the flutter/flutter->flutter/packages roll, which is many days behind now, by turning off impeller in `google_maps_flutter_android` temporarily until flutter/flutter#152691 is fixed, so that we can roll past the commit that enabled it by default.

The alternative would be turn off device testing of `google_maps_flutter*`, but we've never been able to turn that test on for emulators so that would remove all `google_maps_flutter*` on Android, which is worse from the standpoint of things we need to test in this repo. There are a number of non-trivial changes happening to that package, so we need integration test coverage.
  • Loading branch information
stuartmorgan authored Aug 2, 2024
1 parent 9d33722 commit 869f887
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .ci/flutter_master.version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e2e43987c4fb5803c59d7ceb5048cf08bd22cffe
9d5ede0f5ae511cb3b2f6de2ab9164a428db418e
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>

<application android:label="google_maps_flutter_example" android:icon="@mipmap/ic_launcher">
<meta-data
<!-- Temporary workaround for https://github.com/flutter/flutter/issues/152691 -->
<meta-data
android:name="io.flutter.embedding.android.EnableImpeller"
android:value="false" />
<meta-data
android:name="com.google.android.gms.version"
android:value="@integer/google_play_services_version" />
<!-- Update this value to your google maps api key. -->
Expand Down

0 comments on commit 869f887

Please sign in to comment.