[image_picker] Upgrade mime to v2 #7875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use extensionFromMime() so the breaking change doesn't impact us: https://github.com/dart-lang/tools/blob/main/pkgs/mime/CHANGELOG.md#200
emersion
requested review from
cbracken,
jmagman,
loic-sharma,
gmackall and
ditman
as code owners
|
Oh, contributing requires a CLA. Sorry, I do not wish to surrender my copyright. |
|
@emersion totally understandable. I'm curious if the looser version constraint is causing a problem for you somewhere. If so, enough info for us to file an issue in the issue tracker would be enough to cause an existing contributor to jump out of the woodwork and bump the constraint to 2.0.0. |
|
Good point, opened flutter/flutter#156905 |
cbracken
added a commit
to cbracken/packages
that referenced
this pull request
Oct 15, 2024
Provides version interop for projects that depend on mime version 2.0.0 and later. The breaking version change was due to a change in the return value of `extensionFromMime`, which is unused in `image_picker`. See: https://github.com/dart-lang/tools/blob/main/pkgs/mime/CHANGELOG.md#200 Issue: flutter#7875
12 tasks
|
New patch out at #7879. Thanks for filing the issue. Also thanks for your work on several pieces of software I use daily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use extensionFromMime() so the breaking change doesn't impact us:
https://github.com/dart-lang/tools/blob/main/pkgs/mime/CHANGELOG.md#200
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.