[in_app_purchase_storekit] Add Swift Package Manager compatibility #8469
+119
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../in_app_purchase_storekit/darwin/in_app_purchase_storekit/Sources/storekit_objc/messages.g.m
Outdated
Show resolved
Hide resolved
A number of the automated tests are not buildable in this PR. If you click into the failing CI tasks, click |
LouiseHsu
reviewed
Jan 21, 2025
...hase_storekit/Sources/in_app_purchase_storekit/StoreKit2/InAppPurchasePlugin+StoreKit2.swift
Show resolved
Hide resolved
|
I will fix tree issue tmr |
alejandro-all-win-software
force-pushed
the
feat/in-app-purchase-add-swift-package-manager-support
branch
from
b71a757 to
99a1132
Compare
|
Hmm, I am not sure why the tree status is failing. I though it was because of the main merge in my branch. |
|
|
I see, thank you. |
…packages into feat/in-app-purchase-add-swift-package-manager-support
alejandro-all-win-software
force-pushed
the
feat/in-app-purchase-add-swift-package-manager-support
branch
from
99a1132 to
f415bf0
Compare
Comment on lines
14
to
18
| #if __has_include(<in_app_purchase_storekit/in_app_purchase_storekit.h>) | ||
| @import in_app_purchase_storekit; | ||
| #else | ||
| @import storekit_objc; | ||
| #endif |
There was a problem hiding this comment.
I tried to avoid changing this file but I couldn't find a way.
|
Hey @loic-sharma, whenever you have a chance, could you review these changes, please? Thanks! |
|
@alejandro-all-win-software Per our contributor docs, you should expect a review within two weeks, not 24 hours; please don't ping people just because they haven't immediately reviewed a PR. |
loic-sharma
reviewed
Jan 24, 2025
packages/in_app_purchase/in_app_purchase_storekit/darwin/in_app_purchase_storekit/Package.swift
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
...t/darwin/in_app_purchase_storekit/Sources/storekit_objc/Protocols/FLTMethodChannelProtocol.m
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
...t/darwin/in_app_purchase_storekit/Sources/storekit_objc/Protocols/FLTMethodChannelProtocol.m
Outdated
Show resolved
Hide resolved
…in-app-purchase-add-swift-package-manager-support
loic-sharma
reviewed
Jan 24, 2025
...t/darwin/in_app_purchase_storekit/Sources/in_app_purchase_storekit_objc/FIAPReceiptManager.m
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
..._app_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FIAPPaymentQueueDelegate.h
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
...ces/in_app_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FIAPReceiptManager.h
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
..._app_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FLTMethodChannelProtocol.h
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
...p_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FLTTransactionCacheProtocol.h
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
...ces/in_app_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FIAPReceiptManager.h
Outdated
Show resolved
Hide resolved
…in-app-purchase-add-swift-package-manager-support
loic-sharma
reviewed
Jan 27, 2025
..._app_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FLTMethodChannelProtocol.h
Outdated
Show resolved
Hide resolved
loic-sharma
approved these changes
Jan 27, 2025
LouiseHsu
approved these changes
Jan 27, 2025
loic-sharma
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
in_app_purchase_storekitavailable as a Swift Package to FlutterCloses #146905
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.