-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial pages for Architecture guidance #11300
base: main
Are you sure you want to change the base?
Conversation
…-architecture-first
Visit the preview URL for this PR (updated for commit c20f173): https://flutter-docs-prod--pr11300-ew-app-architecture-first-xhdhrb5w.web.app |
…-architecture-first
…-architecture-first
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ericwindmill! Overall, this looks good. However, are some pages missing? The prev/next progression through the pages ended at the Guide, so I had to manually type in the recommendations page.
Also, Miguel mentioned a malformed table. The table looked fine on my mac. |
…-architecture-first
@sfshaza2 -- There are pages missing. I wanted to split up the PR because theres going to be another PR thats about this same size. For now, I updated the prev/next progression in this PR, and I'll update as needed in future PRs. I addressed all the other comments. You may have to hard refresh your browser to see the missing image. On my computer the broken image was cached. |
Adds the first 3 pages of the architecture guidance documentation.
This PR does not add these pages to the side nav. There will be another PR that fast follows this one and contains a couple more pages of docs, as well as the the side nav.
FYI: These pages have been reviewed by @sfshaza2 in a Google Doc. Of course additional reviews are welcomed.
URL for added pages: https://flutter-docs-prod--pr11300-ew-app-architecture-first-xhdhrb5w.web.app/app-architecture