Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial pages for Architecture guidance #11300

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

ericwindmill
Copy link
Contributor

@ericwindmill ericwindmill commented Oct 22, 2024

Adds the first 3 pages of the architecture guidance documentation.

This PR does not add these pages to the side nav. There will be another PR that fast follows this one and contains a couple more pages of docs, as well as the the side nav.

FYI: These pages have been reviewed by @sfshaza2 in a Google Doc. Of course additional reviews are welcomed.

URL for added pages: https://flutter-docs-prod--pr11300-ew-app-architecture-first-xhdhrb5w.web.app/app-architecture

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Oct 22, 2024

Visit the preview URL for this PR (updated for commit c20f173):

https://flutter-docs-prod--pr11300-ew-app-architecture-first-xhdhrb5w.web.app

@miquelbeltran
Copy link
Member

Not a full review yet, but I noticed that this table did not render correctly for me:
image

Here I am using Chrome on macOS

@sfshaza2
Copy link
Contributor

/gcbrun

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ericwindmill! Overall, this looks good. However, are some pages missing? The prev/next progression through the pages ended at the Guide, so I had to manually type in the recommendations page.

src/content/app-architecture/index.md Show resolved Hide resolved
src/content/app-architecture/index.md Outdated Show resolved Hide resolved
@sfshaza2
Copy link
Contributor

sfshaza2 commented Oct 31, 2024

Also, Miguel mentioned a malformed table. The table looked fine on my mac.

@sfshaza2 sfshaza2 added the review.await-update Awaiting Updates after Edits label Nov 1, 2024
@ericwindmill
Copy link
Contributor Author

Hi @ericwindmill! Overall, this looks good. However, are some pages missing? The prev/next progression through the pages ended at the Guide, so I had to manually type in the recommendations page.

@sfshaza2 -- There are pages missing. I wanted to split up the PR because theres going to be another PR thats about this same size. For now, I updated the prev/next progression in this PR, and I'll update as needed in future PRs.

I addressed all the other comments. You may have to hard refresh your browser to see the missing image. On my computer the broken image was cached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review.await-update Awaiting Updates after Edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants