Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android_intent_plus): adds error catching and forwarding #3451

Closed

Conversation

ViscousPot
Copy link
Contributor

@ViscousPot ViscousPot commented Jan 31, 2025

Description

Currently, when sending an intent, any native errors occur silently without any notification to the flutter side of code.
This adds error forwarding back to flutter through the MethodCaller.

This can be tested by trying to send an intent to an Activity that doesn't exist.
Previous behaviour, it would show a native error in the log but this is not catchable in flutter code
New behaviour forwards the error and allows it to be caught

Related Issues

No related issues exist for this

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@ViscousPot ViscousPot force-pushed the feat/add-error-catching branch from 3536133 to 122d73c Compare January 31, 2025 23:50
@ViscousPot ViscousPot closed this Jan 31, 2025
@ViscousPot ViscousPot deleted the feat/add-error-catching branch January 31, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant