updating app versions (in container) #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need to use an updated pydantic-settings and fastapi. This likely will work best in a container, or will need additional tweaks to install the correct version after. It does not seem to resolve perfectly in one requirements.txt, unfortunately. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
|
To summarize problems here:
I'm not happy with this for a production API, and it needs to be totally redone. Likely this would be a good project for Go or similar, or just a more stable API (one with fewer underlying dependencies). I'm removing it from the flux operator for now. |
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to use an updated pydantic-settings and fastapi. This likely will work best in a container, or will need additional tweaks to install the correct version after. It does not seem to resolve perfectly in one requirements.txt, unfortunately.
I don't expect tests to pass - so will come back to work on this more.