Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: Sort header filters to avoid canary restarts #1713

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Gateway API: Sort header filters to avoid canary restarts #1713

wants to merge 2 commits into from

Conversation

mingjie-li
Copy link

@mingjie-li mingjie-li commented Oct 18, 2024 •
edited by stefanprodan
Loading

fix canary analysis restart with gateway api

Fix: #1712

@mingjie-li mingjie-li mentioned this pull request Oct 18, 2024
Open
aryan9600
aryan9600 reviewed Oct 26, 2024
View reviewed changes
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening this PR!

pkg/router/gateway_api.go Outdated Show resolved Hide resolved
pkg/router/gateway_api_test.go Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.06%. Comparing base (2d5e289) to head (b88e080).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
pkg/router/gateway_api.go 76.92% 2 Missing and 1 partial ⚠️
pkg/router/gateway_api_v1beta1.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
+ Coverage   34.44%   35.06%   +0.61%     
==========================================
  Files         283      283              
  Lines       20691    24645    +3954     
==========================================
+ Hits         7128     8642    +1514     
- Misses      12627    15063    +2436     
- Partials      936      940       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanprodan stefanprodan changed the title fix #1712 : sort gateway api header fileter to fix canary restart Gateway API: Sort header filters to avoid canary restarts Nov 1, 2024
stefanprodan
stefanprodan approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mingjie-li 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@aryan9600 aryan9600 Awaiting requested review from aryan9600 aryan9600 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canary analysis restart again and again when using Gateway API
4 participants
@mingjie-li @codecov-commenter @stefanprodan @aryan9600