Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shell command in README #136

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix shell command in README #136

merged 1 commit into from
Jan 15, 2025

Conversation

ilkimo
Copy link
Contributor

@ilkimo ilkimo commented Jan 14, 2025

If applied, this commit will correct the yq command to extract the public key from the secret.

Changes done:

  • fix the $ yq .stringData key path
  • remove the "| base64 --decode" as the key is not encoded when generated by the $ flux create secret git command
  • use the proper path to the file according to the previous command in the README step-by-step explanation

The proper use of the $ yq command can also be verified directly in the official help section $ flux create secret git --help
Launch it and search for "yq" to jump directly to the --help example.

If applied, this commit will correct the yq command to extract the public key from the secret.

Signed-off-by: il_kimo <[email protected]>
@matheuscscp
Copy link
Member

@stefanprodan The workflow is not getting triggered 🤔 I'm also not seeing it in the files. Should this requirement be removed from the settings?

@stefanprodan stefanprodan merged commit 094bc45 into fluxcd:main Jan 15, 2025
2 checks passed
@stefanprodan
Copy link
Member

@matheuscscp that e2e workflow is for own branches, not PRs from forks, we could remove the requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants