-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store digest of latest image in ImagePolicy status #368
base: main
Are you sure you want to change the base?
Commits on Sep 20, 2023
-
Store digest of latest image in ImagePolicy's status
The new API field `.status.latestDigest` in the `ImagePolicy` kind stores the digest of the image referred to by the the `.status.latestImage` field. The setting of this field is governed by the newly introduced field `.spec.digestReflectionPolicy` which takes one of the values `Always` or `IfNotPresent`. See the updated documentation under `docs/spec/` for details. The new status field can be used to pin an image to an immutable descriptor rather than to a potentially moving tag, increasing the security of workloads deployed on a cluster. The goal is to make use of the digest in IAC so that manifests can be updated with the actual image digest. Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 727aff4 - Browse repository at this point
Copy the full SHA 727aff4View commit details -
Introduce ImagePolicy.Status.LatestRef field
This new field summarizes all data reflecting an image reference, i.e. the repository name, tag and digest. Since this change changes the API in a backwards-incompatible way, the new API version v1beta3 is introduced. Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for ab8a91a - Browse repository at this point
Copy the full SHA ab8a91aView commit details -
Add "Never" as a valid value for .spec.digestReflectionPolicy
This way we circumvent issues with server-side apply so that users can explicitly change this field instead of having to remove it. The latter case might lead to the API server not removing it if another field manager is registered for that field, causing an unintended drift. This commit also aligns the v1beta3 API with the latest changes done in v1beta2. Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 111fe05 - Browse repository at this point
Copy the full SHA 111fe05View commit details -
Revert introduction of v1beta3
We agreed to make the changes in the existing v1beta2 API version. Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 5f4903b - Browse repository at this point
Copy the full SHA 5f4903bView commit details -
Fix up print columns to reflect changes in ImagePolicy status
Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 99b5126 - Browse repository at this point
Copy the full SHA 99b5126View commit details -
Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for c85404e - Browse repository at this point
Copy the full SHA c85404eView commit details -
Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 7fa66fb - Browse repository at this point
Copy the full SHA 7fa66fbView commit details -
Address remaining review comments
Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 3cd160b - Browse repository at this point
Copy the full SHA 3cd160bView commit details -
.spec.image has no relevance in the given package, anymore. Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for efefbd5 - Browse repository at this point
Copy the full SHA efefbd5View commit details -
Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 6e3a989 - Browse repository at this point
Copy the full SHA 6e3a989View commit details -
Remove noop statements from test
These must have been leftovers from previous iterations of this test. Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for a3e050f - Browse repository at this point
Copy the full SHA a3e050fView commit details -
Some small API changes to ImagePolicy
1. Default digestReflectionPolicy to "Never" and add a getter. With the getter method we will never encounter an empty policy even if defaulting hasn't taken place. 2. Make status.latestRef a pointer to align with status.observedPreviousRef. Having both fields be pointers makes it easier to use them in code so we only have to compare to nil and not the zero value. Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for af0fa03 - Browse repository at this point
Copy the full SHA af0fa03View commit details -
Add proper setting of .status.observedPreviousRef
The field hasn't been set properly before. Correct behaviour is backed by associated unit tests. Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for b787e9c - Browse repository at this point
Copy the full SHA b787e9cView commit details -
The updated documentation has gotten lost due to the back and forth with v1beta3. Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 5cfa766 - Browse repository at this point
Copy the full SHA 5cfa766View commit details
Commits on Oct 2, 2023
-
Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedOct 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 6c9b87e - Browse repository at this point
Copy the full SHA 6c9b87eView commit details -
Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedOct 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 962576b - Browse repository at this point
Copy the full SHA 962576bView commit details
Commits on Oct 4, 2023
-
Signed-off-by: Max Jonas Werner <[email protected]>
Max Jonas Werner committedOct 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 13c2f70 - Browse repository at this point
Copy the full SHA 13c2f70View commit details