Commit status notifications: Add optional prefix to commit status key #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcarrier92
force-pushed
the
add-optional-meta-info-to-commit-status
branch
2 times, most recently
from
1b013ca
to
7b7ffe8
Compare
bcarrier92
changed the title
This commit aims to extend the functionality of commit status notifications. It adds an optional key `commitStatusPrefix` to the Provider spec so that notification controllers in different environments don't overwrite a commit status for a particular resource. Example use-case: a single object (kustomization/k8s-gitops) is deployed to multiple clusters. Specifying this (e.g. to the name of the cluster) ensures that the notification controllers on each cluster don't overwrite each others' commit statuses when reporting on kustomization/k8s-gitops. Signed-off-by: bcarrier <[email protected]>
bcarrier92
force-pushed
the
add-optional-meta-info-to-commit-status
branch
from
7b7ffe8
to
de8c7a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to extend the functionality of commit status notifications. It adds an optional key
commitStatusPrefixto the Provider spec so that notification controllers in different environments don't overwrite a commit status for a particular resource.Example use-case: a single object (kustomization/k8s-gitops) is deployed to multiple clusters. Specifying this (e.g. to the name of the cluster) ensures that the notification controllers on each cluster don't overwrite each others' commit statuses when reporting on kustomization/k8s-gitops.