Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra tags to Grafana annotations #405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bilbof
Copy link

@bilbof bilbof commented Aug 16, 2022

This adds the name and namespace tags to Grafana annotations.

This makes it possible to use the Grafana provider when one has multiple Flux tenants writing to the same Grafana instance.

This adds the name and namespace tags to Grafana annotations.

This makes it possible to use this provider when one has multiple
Flux tenants writing to the same Grafana instance.

Signed-off-by: Bill Franklin <[email protected]>
@bilbof
Copy link
Author

bilbof commented Aug 16, 2022

I can also add reason in here, that might be useful

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makkes
Copy link
Member

makkes commented Aug 23, 2022

@bilbof if you need assistance in documenting this change, I'd be happy to help getting this PR merged. Just let me know.

@Dariusch
Copy link

Dariusch commented Oct 6, 2022

Hey guys, any updates on this PR? I'd like to see this one get merged.

Regarding the documentation: This PR is only adding additional tags. The current tags are not documented anywhere

@Dariusch
Copy link

Dariusch commented Dec 5, 2022

@stefanprodan sorry to ping you, but the PR is not moving forward, though it's an easy fix...

How can we help to get this PR merged?

@cmitri-harris
Copy link

Any chance this got merged?

@stefanprodan
Copy link
Member

This PR is abandoned, but since this was opened, things have evolved. You can add metadata in the Alert that will end up as Grafana annotations, for example:

apiVersion: notification.toolkit.fluxcd.io/v1beta3
kind: Alert
metadata:
  name: <name>
spec:
  eventMetadata:
    tenant: "team1"
    env: "production"
    region: "us-east-1"

@cmitri-harris
Copy link

Thanks @stefanprodan for responding.
The advantage of having the namespace and name as tags is that the values are dynamically assigned.
I tried to expand variables in eventMetadata but didn't work.
Since we have multiple namespaces and applications, now I'm creating multiple Alerts with static eventMetadata for each.
Ultimately, one Alert definition should cover all and in Grafana, we filter accordingly.

@stefanprodan
Copy link
Member

@cmitri-harris feel free to open a new PR for this, we can close this one and review yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants