Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add severity to opsgenie alerts #796

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Add severity to opsgenie alerts #796

merged 1 commit into from
Apr 19, 2024

Conversation

al-lac
Copy link
Contributor

@al-lac al-lac commented Apr 17, 2024

Add severity to opsgenie alerts to better be able to handle the opening and closing of alerts.

Related to #460

@al-lac al-lac force-pushed the opsgenie-add-severity branch from 229a7a9 to fd4d739 Compare April 17, 2024 07:48
@al-lac al-lac force-pushed the opsgenie-add-severity branch from 8377fee to 410865f Compare April 17, 2024 08:27
@stefanprodan
Copy link
Member

Please run make test before committing, the code is not properly formatted.

@stefanprodan
Copy link
Member

I suggest you build the controller image and deploy it on your cluster to test if this actually works, I bet it doesn't. I see no field named severity in the API https://developer.atlassian.com/cloud/jira/service-desk-ops/rest/v1/api-group-integration-events/

@al-lac
Copy link
Contributor Author

al-lac commented Apr 17, 2024

@stefanprodan yeah i think i need to rework this. Give me some time to come up with something else.

@al-lac
Copy link
Contributor Author

al-lac commented Apr 17, 2024

Added the severity now to the details payload, this should hopefully be the easiest solution.

@al-lac al-lac requested a review from souleb April 18, 2024 06:37
@souleb
Copy link
Member

souleb commented Apr 18, 2024

@al-lac I have added the test. Can you test that this works in your cluster?

@al-lac
Copy link
Contributor Author

al-lac commented Apr 18, 2024

@souleb works in my cluster and shows the severity in opsgenie now 🎉
CleanShot 2024-04-18 at 15 57 02@2x

souleb
souleb approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@souleb souleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @al-lac

@souleb
Copy link
Member

souleb commented Apr 19, 2024

@al-lac can you squash your commits please?

@al-lac al-lac mentioned this pull request Apr 19, 2024
Open
@al-lac al-lac force-pushed the opsgenie-add-severity branch from 638e0da to 1b96ece Compare April 19, 2024 10:31
@souleb
Copy link
Member

souleb commented Apr 19, 2024

Please also update the commit message.

@al-lac al-lac force-pushed the opsgenie-add-severity branch from 1b96ece to 94ce6da Compare April 19, 2024 12:37
@al-lac
Copy link
Contributor Author

al-lac commented Apr 19, 2024

@souleb i hope it is fine like this now.

@souleb souleb merged commit f22dd2b into fluxcd:main Apr 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souleb souleb souleb approved these changes

@PatrickZeier-SAG PatrickZeier-SAG Awaiting requested review from PatrickZeier-SAG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@al-lac @stefanprodan @souleb @PatrickZeier-SAG