runtime/controller: add generic flag for allowing insecure HTTP conne…

…ctions

Add a generic flag `--insecure-allow-http` to allow users to enable the
use of plain HTTP connections.

Signed-off-by: Sanskar Jaiswal <[email protected]>

runtime/controller/connection.go

@@ -0,0 +1,35 @@
+/*
+Copyright 2023 The Flux authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package controller
+
+import "github.com/spf13/pflag"
+
+const flagInsecureAllowHTTP = "insecure-allow-http"
+
+// ConnectionOptions defines the configurable options for outbound connections
+// opened by reconcilers.
+type ConnectionOptions struct {
+	// AllowHTTP, if set to true allows the controller to make plain HTTP
+	// connections to external services.
+	AllowHTTP bool
+}
+
+// BindFlags will parse the given pflag.FlagSet for the controller and
+// set the ConnectionOptions accordingly.
+func (o *ConnectionOptions) BindFlags(fs *pflag.FlagSet) {
+	fs.BoolVar(&o.AllowHTTP, flagInsecureAllowHTTP, false, "Allow the controller to make HTTP requests.")
+}