git: Add support for adding tag info to commit #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
force-pushed
the
tag-verification
branch
from
01f1d62
to
320e110
Compare
|
Is this part of fluxcd/source-controller#1133? if so please add it to the PR description. |
aryan9600
force-pushed
the
tag-verification
branch
from
320e110
to
7aaad57
Compare
hiddeco
reviewed
Jul 3, 2023
darkowlzz
reviewed
Jul 24, 2023
aryan9600
force-pushed
the
tag-verification
branch
2 times, most recently
from
721ba7d
to
0830185
Compare
hiddeco
reviewed
Aug 7, 2023
aryan9600
force-pushed
the
tag-verification
branch
from
0830185
to
432ebdc
Compare
aryan9600
force-pushed
the
tag-verification
branch
from
432ebdc
to
75e7516
Compare
|
wondering whether we should also add support for verifying tags if the name provided to |
|
If we can automagically resolve this, it would probably be good for feature completeness. |
hiddeco
reviewed
Aug 10, 2023
aryan9600
force-pushed
the
tag-verification
branch
from
c35892e
to
6125c92
Compare
hiddeco
approved these changes
Aug 14, 2023
aryan9600
force-pushed
the
tag-verification
branch
2 times, most recently
from
b79297f
to
c38eab8
Compare
hiddeco
reviewed
Aug 17, 2023
aryan9600
force-pushed
the
tag-verification
branch
2 times, most recently
from
fbb668e
to
8fe69f8
Compare
hiddeco
approved these changes
Aug 18, 2023
stefanprodan
approved these changes
Aug 21, 2023
Add a new struct `AnnotatedTag` that represents a Git annotated tag and add it as a new field `Commit.ReferencingTag`, allowing for a commit to contain information about its referencing tag. Add support for verifying referecning tag as well. Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
Add support for lightweight tags by checking the presence of a tag reference and a tag object. Modify the cloning logic to always attach a tag object to a commit object if checking out via a tag. Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
tag-verification
branch
from
8fe69f8
to
0f40956
Compare
|
Failing BitBucket Server test is due to TLS issues on the upstream server and not related to these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new struct
Tagthat represents a Git annotated tag and add it as a new fieldCommit.ReferencingTag, allowing for a commit to contain information about its referencing tag. Add support for verifying the referencing tag as well.Update the cloning logic to include the tag object in the returned commit object when checking out via a specific tag, a semver range or if the provided refname points to a tag.
Related to: fluxcd/source-controller#1133
Example usage: fluxcd/source-controller#1187