ssa: Detect immutable errors from CEL and custom webhooks #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
added
the
area/server-side-apply
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
cel-immutablility
branch
from
eb41f80
to
03c49d6
Compare
hiddeco
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom admission webhooks such as those used by Google Cloud and Kubernetes CEL which reject requests due to immutable field changes do not comply with
errors.IsInvalid. For Flux to be able to force apply resources rejected by these controllers, we have to do a match on the error string and look foris immutable.Ref: