-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update explanation on Helm use case #1375
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Somtochi Onyekwere <[email protected]>
@stefanprodan I don't know if we want to add an beginning section where we say we expect them to have flux bootstrapped |
@somtochiama yes, we need to tell people to bootstrap and link to the install doc. |
Signed-off-by: Somtochi Onyekwere <[email protected]>
content/en/flux/use-cases/helm.md
Outdated
flux create helmrelease my-traefik --chart traefik \ | ||
--source HelmRepository/traefik \ | ||
--chart-version 9.18.2 \ | ||
--namespace traefik \ | ||
--export > /flux/boot/traefik/helmrepo.yaml | ||
--export > traefik/helmrepo.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please test this with Kind, I guess the HR will fail due to the lack of LB support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose we replace traefik with nginx, and then we can use the HR from here which is e2e tested on Kind. https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/infrastructure/controllers/ingress-nginx.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefanprodan you are right
Helm install failed: timed out waiting for the condition │
│
Last Helm logs: │
│
creating 1 resource(s) │
CRD traefikservices.traefik.containo.us is already present. Skipping. │
creating 5 resource(s) │
beginning wait for 5 resources with timeout of 5m0s │
Service does not have load balancer ingress IP address: flux-system/my-traefik
I will update it to use nginx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nginx also has the same problem. Should we use podinfo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nginx does not have this issue, see the values used in the link I posted above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the usecase guide, values are introduced in a later section after the helm release is applied.
So I was thinking we could start with something that just works without tweaking the values first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK lets' use Flagger.
Signed-off-by: Somtochi Onyekwere <[email protected]>
The explanation after the
flux create source helm
command seems to imply that the command will commit the files to git.This pull request tries to fix that.
Ref: https://cloud-native.slack.com/archives/CLAJ40HV3/p1676320569584019
Signed-off-by: Somtochi Onyekwere [email protected]