Add note to image-update.md about namespaces #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an ImageUpdateAutomation is specified in namespace A, the image-automation controller will select imagepolicy setters which match the namespace of the ImageUpdateAutomation object
|
@jiphex can you sign off your commit please? thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ImageUpdateAutomation is specified in namespace A, the image-automation controller will select imagepolicy setters which match the namespace of the ImageUpdateAutomation object (A), and silently skip any
{"$imagepolicy":"nota:whatever"}commentsThis caused me some confusion for a while - in our case we have a single
flux-systemImageUpdateAutomation resource in our bootstrapped flux repositories, and because this wasn't explicitly mentioned at this point in the docs, I assumed it would make more sense to put the ImagePolicy and ImageRepository resources in the namespaces of their relevant deployments, rather than in theflux-systemone, however these aren't found by the image-automation setters.The language could be improved, but I was struggling to word the explanation.