Do not use case class for classes with mutable Arrays

flvrone · Jan 16, 2025 · e4d083c · e4d083c
1 parent faa2939
commit e4d083c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/10/hiking_trails.scala b/10/hiking_trails.scala
@@ -33,7 +33,7 @@ case class Height2DMap(rows: Vector[Vector[Int]]):
 
 case class MapTile(height: Int, visited: Boolean = false)
 
-case class Visitable2DMap(heightMap: Height2DMap):
+class Visitable2DMap(heightMap: Height2DMap):
   val visitableRows = heightMap.rows.map(row => row.map(MapTile(_)).toArray)
 
   def tileAt(row: Int, col: Int): Option[MapTile] =

diff --git a/12/discounted_fence.scala b/12/discounted_fence.scala
@@ -37,7 +37,7 @@ case class Char2DMatrix(lines: Vector[String]):
 
 case class MapTile(identifier: Char, visited: Boolean = false)
 
-case class Visitable2DMap(map: Char2DMatrix):
+class Visitable2DMap(map: Char2DMatrix):
   val visitableRows = map.lines.map(line => line.map(MapTile(_)).toArray)
 
   def tileAt(row: Int, col: Int): Option[MapTile] =

diff --git a/12/garden_groups.scala b/12/garden_groups.scala
@@ -37,7 +37,7 @@ case class Char2DMatrix(lines: Vector[String]):
 
 case class MapTile(identifier: Char, visited: Boolean = false)
 
-case class Visitable2DMap(map: Char2DMatrix):
+class Visitable2DMap(map: Char2DMatrix):
   val visitableRows = map.lines.map(line => line.map(MapTile(_)).toArray)
 
   def tileAt(row: Int, col: Int): Option[MapTile] =

diff --git a/6/patrol_loops.scala b/6/patrol_loops.scala
@@ -45,7 +45,7 @@ case class Tile2DMap(rows: Vector[Vector[MapTile]]):
   def tileAt(coord: Coord): Option[MapTile] =
     tileAt(coord.row, coord.col)
 
-case class Visitable2DMap(tileMap: Tile2DMap):
+class Visitable2DMap(tileMap: Tile2DMap):
   val visitableRows = tileMap.rows.map(_.toArray)
 
   def tileAt(row: Int, col: Int): Option[MapTile] =

diff --git a/6/patrol_map.scala b/6/patrol_map.scala
@@ -13,7 +13,9 @@ def main1(inputFileName: String): Unit =
   traverseMapFromPosition(map, position)
 
   val visitedCount =
-    map.rows.map(_.count(_ == MapTile.VisitedPath)).reduce(_ + _)
+    map.rows
+    .map(row => row.count(_ == MapTile.VisitedPath))
+    .sum
 
   println(visitedCount)
 
@@ -27,7 +29,7 @@ case class Position(coord: Coord, dir: Direction)
 enum MapTile:
   case Obstacle, Path, VisitedPath
 
-case class Visitable2DMap(rows: Vector[Array[MapTile]]):
+class Visitable2DMap(val rows: Vector[Array[MapTile]]):
   def rowAt(idx: Int): Option[Array[MapTile]] =
     if idx >= 0 && idx < rows.length then
       Some(rows.apply(idx))