Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): .simbridgedebug command #478

Merged
merged 12 commits into from
Aug 27, 2023

Conversation

Lauvaan
Copy link
Contributor

@Lauvaan Lauvaan commented Jun 29, 2023

Description

Fixes: #473

A command that explains the reason for simbridge crashing, and provides steps to send a screenshot that support can use to debug the situation.

Test Results

(don't have an image server up(and didn't bother setting up one rn) to showcase the image, but it should work)
image

Discord Username

@Lauvaan
Copy link
Contributor Author

Lauvaan commented Jun 29, 2023

Going to get screenshots and add changelog after I get back home, now have only chromebook and github.dev, so can't take the screenshots.

Copy link
Collaborator

@NUTTTTTTTT NUTTTTTTTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understand you're not done with this yet, but a couple of bits to look at when you're home and wrapping up the PR to save waiting for a review twice 😄

Looking great though!

.github/command-docs.md Outdated Show resolved Hide resolved
src/commands/support/simbridgeDebug.ts Outdated Show resolved Hide resolved
src/commands/support/simbridgeDebug.ts Outdated Show resolved Hide resolved
src/commands/support/simbridgeDebug.ts Outdated Show resolved Hide resolved
src/commands/support/simbridgeDebug.ts Outdated Show resolved Hide resolved
src/commands/support/simbridgeDebug.ts Outdated Show resolved Hide resolved
src/commands/support/simbridgeDebug.ts Outdated Show resolved Hide resolved
@benw202 benw202 added the changes requested changes requested, awaiting response before merge label Jun 30, 2023
@Lauvaan Lauvaan marked this pull request as ready for review July 24, 2023 07:45
@pdellaert
Copy link
Collaborator

@Lauvaan, can you add a CHANGELOG entry? and have a quick look at the lint error? (seems like there's unnecessary escapes)

@Lauvaan
Copy link
Contributor Author

Lauvaan commented Jul 27, 2023

@Lauvaan, can you add a CHANGELOG entry? and have a quick look at the lint error? (seems like there's unnecessary escapes)

Yep, gonna do it on the weekend probably, if I have time

@benw202 benw202 requested a review from NUTTTTTTTT August 7, 2023 17:01
Copy link
Collaborator

@NUTTTTTTTT NUTTTTTTTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from this, LGTM x

src/commands/support/simbridgeDebug.ts Outdated Show resolved Hide resolved
@Lauvaan Lauvaan requested a review from NUTTTTTTTT August 7, 2023 17:47
@benw202
Copy link
Member

benw202 commented Aug 7, 2023

Aside from this, LGTM x

Thanks! Can you merge when approved pls

@Valastiri Valastiri merged commit a0b98c5 into flybywiresim:staging Aug 27, 2023
4 checks passed
@Lauvaan Lauvaan deleted the feat-.simbridgedebug-command branch August 27, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested changes requested, awaiting response before merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command for simbridge debug
5 participants