Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding support for embeds and referenced messages in delete log #488

Merged
merged 5 commits into from
Aug 27, 2023

Conversation

pdellaert
Copy link
Collaborator

@pdellaert pdellaert commented Jul 19, 2023

[Enhancing ](feat: Adding support for embeds and referenced messages in delete log)

Description

Introduces the following to the user delete log handler:

  • Optimize embeddings
  • Adds data for when embeds get deleted (text and urls for images for instance)
  • Adds details if attachments are used
  • Adds reference to a message if the deleted message is a reply to another message (ghost ping prevention among one of the reasons)

Test Results

Screenshot 2023-07-18 at 8 56 18 PM Screenshot 2023-07-18 at 8 56 32 PM Screenshot 2023-07-18 at 8 59 45 PM Screenshot 2023-07-18 at 9 00 02 PM Screenshot 2023-07-18 at 9 02 10 PM Screenshot 2023-07-18 at 9 02 27 PM Screenshot 2023-07-18 at 9 02 52 PM Screenshot 2023-07-18 at 9 03 04 PM Screenshot 2023-07-18 at 9 03 52 PM Screenshot 2023-07-18 at 9 04 05 PM Screenshot 2023-07-18 at 9 15 29 PM Screenshot 2023-07-18 at 9 15 46 PM Screenshot 2023-07-18 at 9 16 35 PM Screenshot 2023-07-18 at 9 16 45 PM Screenshot 2023-07-18 at 9 16 55 PM Screenshot 2023-07-18 at 9 18 31 PM Screenshot 2023-07-18 at 9 18 40 PM Screenshot 2023-07-18 at 9 18 49 PM

Discord Username

straks

@pdellaert
Copy link
Collaborator Author

Condensed data a bit more together, minor improvement

Screenshot 2023-07-18 at 9 31 26 PM Screenshot 2023-07-18 at 9 31 33 PM Screenshot 2023-07-18 at 9 31 52 PM

@pdellaert pdellaert requested a review from benw202 July 19, 2023 04:40
src/handlers/messagedelete.ts Outdated Show resolved Hide resolved
src/handlers/messagedelete.ts Outdated Show resolved Hide resolved
@pdellaert
Copy link
Collaborator Author

Thanks for the bug catching, @Sleinmaster. I'll look at the loop stuff soon with some extra testing

@pdellaert pdellaert merged commit d26db7d into flybywiresim:staging Aug 27, 2023
4 checks passed
@pdellaert pdellaert deleted the enhance-delete-handler branch August 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants