Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update takeoff calculator command to highlight new ongoing development #496

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

pdellaert
Copy link
Collaborator

@pdellaert pdellaert commented Sep 4, 2023

fix: Update takeoff calculator command to highlight new ongoing development

Description

Fixes #495

Test Results

Screenshot 2023-09-04 at 2 04 10 PM

Discord Username

straks

@pdellaert pdellaert marked this pull request as draft September 4, 2023 20:32
@pdellaert pdellaert added do not merge Don't merge this PR pending internal discussion bot/mod/dev team discussion taking place before merge and removed do not merge Don't merge this PR pending internal discussion bot/mod/dev team discussion taking place before merge labels Sep 4, 2023
@pdellaert pdellaert marked this pull request as ready for review September 4, 2023 20:42
.github/CHANGELOG.md Outdated Show resolved Hide resolved
@Valastiri
Copy link
Member

I think we shouldn't remove the existing text. We can put what you've done at the top or bottom fo the command and remove the last line that starts with "This unfortunately [...]".

So it's clear that the information is hard to come by -- but we are coming up with a solution i.e. in development.

Thoughts?

@benw202
Copy link
Member

benw202 commented Sep 5, 2023

I think we shouldn't remove the existing text. We can put what you've done at the top or bottom fo the command and remove the last line that starts with "This unfortunately [...]".

So it's clear that the information is hard to come by -- but we are coming up with a solution i.e. in development.

Thoughts?

I also think this would be good

@benw202
Copy link
Member

benw202 commented Oct 11, 2023

Bump

@pdellaert
Copy link
Collaborator Author

Updated changes

image

src/commands/aircraft/flex-temp.ts Outdated Show resolved Hide resolved
src/commands/aircraft/takeoffPerf.ts Outdated Show resolved Hide resolved
src/commands/aircraft/takeoffPerf.ts Show resolved Hide resolved
src/commands/aircraft/takeoffPerf.ts Outdated Show resolved Hide resolved
@pdellaert
Copy link
Collaborator Author

Updated Developer to Development, for "Branch" versus "Version": we use versions everywhere, so I'm keeping those designations.

@pdellaert pdellaert merged commit 47fcfa4 into flybywiresim:staging Jul 1, 2024
4 checks passed
@pdellaert pdellaert deleted the 495-update-perf-command branch July 1, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update perf command with new information
7 participants