Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APmodes #526

Merged
merged 6 commits into from
Aug 8, 2024
Merged

feat: APmodes #526

merged 6 commits into from
Aug 8, 2024

Conversation

LunakisDev
Copy link
Contributor

Description

This command helps people understand the difference between "Managed" & "Selected" AP modes. The user can execute the command by typing .APmodes OR .apmodes.

Test Results

image

Here is the full image of the embed:
image

Discord Username

LunakisLeaks

@LunakisDev LunakisDev changed the title - feat: APmodes feat: APmodes Jul 4, 2024
Copy link
Contributor

@ExampleWasTaken ExampleWasTaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion for improvement. Otherwise looks good!

src/commands/support/apmodes.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ExampleWasTaken ExampleWasTaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@oim1 oim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good codewise, if everyone else is happy with the colours on the image then it's good to merge.

@benw202
Copy link
Member

benw202 commented Jul 11, 2024

Can you add this command to command-docs.md

LunakisDev and others added 2 commits July 11, 2024 20:25
@benw202 benw202 merged commit 0251acb into flybywiresim:staging Aug 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants