lint + update unit test

flyteorg · Dec 4, 2023 · 770c9cd · 770c9cd
1 parent 324cfa7
commit 770c9cd
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/flyteadmin/pkg/manager/impl/task_execution_manager_test.go b/flyteadmin/pkg/manager/impl/task_execution_manager_test.go
@@ -442,6 +442,7 @@ func TestCreateTaskEvent_UpdateTerminalEventError(t *testing.T) {
 	taskEventRequest.Event.Phase = core.TaskExecution_FAILED
 	taskEventRequest.Event.PhaseVersion = uint32(0)
 	taskExecManager = NewTaskExecutionManager(repository, getMockExecutionsConfigProvider(), getMockStorageForExecTest(context.Background()), mockScope.NewTestScope(), mockTaskExecutionRemoteURL, nil, nil)
+	resp, err = taskExecManager.CreateTaskExecutionEvent(context.Background(), taskEventRequest)
 	assert.Nil(t, resp)
 	adminError = err.(flyteAdminErrors.FlyteAdminError)
 	assert.Equal(t, adminError.Code(), codes.FailedPrecondition)
@@ -454,13 +455,10 @@ func TestCreateTaskEvent_UpdateTerminalEventError(t *testing.T) {
 	taskEventRequest.Event.Phase = core.TaskExecution_SUCCEEDED
 	taskEventRequest.Event.PhaseVersion = uint32(0)
 	taskExecManager = NewTaskExecutionManager(repository, getMockExecutionsConfigProvider(), getMockStorageForExecTest(context.Background()), mockScope.NewTestScope(), mockTaskExecutionRemoteURL, nil, nil)
+	resp, err = taskExecManager.CreateTaskExecutionEvent(context.Background(), taskEventRequest)
 	assert.Nil(t, resp)
 	adminError = err.(flyteAdminErrors.FlyteAdminError)
-	assert.Equal(t, adminError.Code(), codes.FailedPrecondition)
-	details, ok = adminError.GRPCStatus().Details()[0].(*admin.EventFailureReason)
-	assert.True(t, ok)
-	_, ok = details.GetReason().(*admin.EventFailureReason_AlreadyInTerminalState)
-	assert.True(t, ok)
+	assert.Equal(t, adminError.Code(), codes.AlreadyExists)
 
 	// request w/ same terminal phase, later version
 	taskEventRequest.Event.Phase = core.TaskExecution_SUCCEEDED