removed Enabled flags in favor of a single ExporterType in config

Signed-off-by: Daniel Rammer <[email protected]>
flyteorg · Nov 8, 2023 · ebddf82 · ebddf82
1 parent c341f9d
commit ebddf82
Show file tree

Hide file tree

Showing 3 changed files with 203 additions and 4 deletions.
diff --git a/flytestdlib/otelutils/config_flags.go b/flytestdlib/otelutils/config_flags.go
diff --git a/flytestdlib/otelutils/config_flags_test.go b/flytestdlib/otelutils/config_flags_test.go
diff --git a/flytestdlib/otelutils/factory_test.go b/flytestdlib/otelutils/factory_test.go
@@ -11,21 +11,19 @@ func TestRegisterTracerProvider(t *testing.T) {
 	serviceName := "foo"
 
 	// register tracer provider with no exporters
-	emptyConfig := Config{}
-	err := RegisterTracerProvider(serviceName, &emptyConfig)
+	err := RegisterTracerProvider(serviceName, defaultConfig)
 	assert.Nil(t, err)
 
 	// validate no tracerProviders are registered
 	assert.Len(t, tracerProviders, 0)
 
 	// register tracer provider with all exporters
 	fullConfig := Config{
+		ExporterType: FileExporter,
 		FileConfig: FileConfig{
-			Enabled:  true,
 			Filename: "/dev/null",
 		},
 		JaegerConfig: JaegerConfig{
-			Enabled: true,
 		},
 	}
 	err = RegisterTracerProvider(serviceName, &fullConfig)