[BUG] Helm redoc templates - flyte chart - not honoring redoc.enabled in values

[cmontemuino]

Describe the bug

When installing the flyte chart and setting redoc.enabled to false, the redoc deployment and service is still installed.

The problem is in the charts/flyte/templates/redoc/deployment.yaml and charts/flyte/templates/redoc/deployment.yaml. These need to be wrapped by a conditional on the rdoc.enabled value, like it is done with other templates (for example, templates/redis).

Expected behavior

No redoc deployment when installing the flyte chart with redoc.enabled set to false.

Additional context to reproduce

helm repo add flyteorg https://flyteorg.github.io/flyte
helm repo update
helm upgrade flyte -n flyte flyteorg/flyte \
    --set redoc.enabled=false \
    --dry-run > flyte.yaml
cat flyte.yaml| grep "name: redoc"

Above command should not output the redoc deployment and service.

Screenshots

No response

Are you sure this issue hasn't been raised already?

• Yes

Have you read the Code of Conduct?

• Yes

[welcome]

Thank you for opening your first issue here! 🛠

[flixr]

see also #2982

[cmontemuino]

Hi @flixr! It seems like I've missed your previous PR, although it's not completely tackling my reported issue. Your PR is updating the service only (vs service + deployment), and it's for another Chart (flyte-deps vs flyte).

[github-actions]

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

[flixr]

@eapolinario this is an easy fix, please see #5452