charts: honor redoc.enabled=false #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
eapolinario
previously approved these changes
Jun 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5452 +/- ##
==========================================
- Coverage 61.93% 60.98% -0.95%
==========================================
Files 611 793 +182
Lines 36463 51313 +14850
==========================================
+ Hits 22582 31293 +8711
- Misses 11907 17135 +5228
- Partials 1974 2885 +911
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@eapolinario so if I understand that correctly, I also need to update the generated charts and README to match the changes? Is there some script to do that? |
|
@flixr |
also use correct nodeSelector and fix doc Signed-off-by: Felix Ruess <[email protected]>
flixr
force-pushed
the
charts_honor_redoc_disable
branch
from
25e2da0 to
90ba18a
Compare
|
@pingsutw I ran |
eapolinario
approved these changes
Jun 12, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
approved these changes
Jun 12, 2024
|
Congrats on merging your first pull request! 🎉 |
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
also use correct nodeSelector and fix doc Signed-off-by: Felix Ruess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charts: honor
redoc.enabled=falseand also use correct nodeSelector and fix docTracking issue
Example: Closes #4006
Updated version of #2982
Why are the changes needed?
See #4006
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link