Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from flytepropeller - Parallelize Node Evaluations #4155

Conversation

eapolinario
Copy link
Contributor

TL;DR

This PR parallelizes node evaluations by using go channels to call the handleNode function in a separate go routine and then waiting on all evaluations before compiling overall workflow status.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

fixes #3866

Follow-up issue

NA

hamersaw and others added 2 commits July 12, 2023 16:18
Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d9586b0) 58.98% compared to head (f8c56fe) 61.41%.

❗ Current head f8c56fe differs from pull request most recent head 572251f. Consider uploading reports for the commit 572251f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4155      +/-   ##
==========================================
+ Coverage   58.98%   61.41%   +2.42%     
==========================================
  Files         619      372     -247     
  Lines       52804    26643   -26161     
==========================================
- Hits        31146    16362   -14784     
+ Misses      19174     8675   -10499     
+ Partials     2484     1606     -878     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 581 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core feature] Parallelize Node Executions in FlytePropeller
2 participants