-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifact/event processing #4277
Conversation
wild-endeavor
commented
Oct 23, 2023
•
edited
Loading
edited
- Replace the server configuration with a block inside artifacts service configuration - doesn't make sense to share, different services use different ports.
- Add piping in flyte single binary command
- Move init/setmetrickeys to avoid
- Revert change to cloudevent sender made a while back so now it matches master again.
- Add interfaces and structure for handling events.
- Add a sandbox publisher to stdlib and a reader in artifact service.
- Move SetMetricKeys to artifact main since single binary was complaining
- Add cloud provider name constants to stdlib.
- Update artifact server error handling.
- Update server to bind to 0.0.0.0 explicitly
- Add task and workflow event handlers
- Mark some metrics and comments.
- Add fixtures to avoid hitting the default grpc unimplemented endpoints.
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## artifacts-bring-admin-monorepo #4277 +/- ##
==================================================================
- Coverage 59.07% 58.07% -1.01%
==================================================================
Files 387 34 -353
Lines 32915 1784 -31131
==================================================================
- Hits 19446 1036 -18410
+ Misses 11971 657 -11314
+ Partials 1498 91 -1407
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
…a function call, add a ton of debug printing that will be removed later today, update enumer for cloud version, add code to render literal, handle message on the consumer side, add task event handling, workflow to be added later, update the event handler interface to be less verbose, run processing in goroutine, update selects Signed-off-by: Yee Hing Tong <[email protected]>
…/paste Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
…server bind to an explicit 0.0.0.0 Signed-off-by: Yee Hing Tong <[email protected]>
ceb390d
into
artifacts-bring-admin-monorepo