Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence NotFound when get task resource #4388

Merged
merged 4 commits into from
Nov 11, 2023

Merge branch 'master' into no-warning

412792a
Select commit
Loading
Failed to load commit list.
Merged

Silence NotFound when get task resource #4388

Merge branch 'master' into no-warning
412792a
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch failed Nov 11, 2023 in 0s

52.94% of diff hit (target 59.59%)

View this Pull Request on Codecov

52.94% of diff hit (target 59.59%)

Annotations

Check warning on line 104 in flyteadmin/pkg/executioncluster/impl/random_cluster_selector.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/executioncluster/impl/random_cluster_selector.go#L104

Added line #L104 was not covered by tests

Check warning on line 429 in flyteadmin/pkg/manager/impl/execution_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/manager/impl/execution_manager.go#L428-L429

Added lines #L428 - L429 were not covered by tests

Check warning on line 46 in flyteadmin/pkg/manager/impl/executions/quality_of_service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/manager/impl/executions/quality_of_service.go#L46

Added line #L46 was not covered by tests