Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect subNode phase updates to reduce evaluation frequency of ArrayNode #4535

Merged
merged 5 commits into from
Dec 8, 2023

Merge branch 'master' into performance/arraynode-subnode-transition-l…

a2ed1a2
Select commit
Loading
Failed to load commit list.
Merged

Detect subNode phase updates to reduce evaluation frequency of ArrayNode #4535

Merge branch 'master' into performance/arraynode-subnode-transition-l…
a2ed1a2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 8, 2023 in 0s

58.92% (+0.00%) compared to f440278

View this Pull Request on Codecov

58.92% (+0.00%) compared to f440278

Details

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f440278) 58.92% compared to head (a2ed1a2) 58.92%.

Files Patch % Lines
...ytepropeller/pkg/controller/nodes/array/handler.go 90.00% 0 Missing and 1 partial ⚠️
flytepropeller/pkg/controller/nodes/executor.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4535   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files         620      620           
  Lines       52432    52441    +9     
=======================================
+ Hits        30896    30903    +7     
- Misses      19071    19073    +2     
  Partials     2465     2465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.