Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artf/cleanup post shell #4646

Merged
merged 11 commits into from
Dec 29, 2023
Merged

Artf/cleanup post shell #4646

merged 11 commits into from
Dec 29, 2023

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Dec 28, 2023

Now that the first shell pr has been merged into master, we're doing some clean up work.

  • Remove the inputs/outputs logic from the cloud publisher on the admin side and move it to the event handler on the artifact side
  • Remove the initialization sql bit and made hstore extension creation just a migration
  • Refactor the handler to be outside of the receiver in artifact events
  • Add adminclient into the servicecallhandler object
  • Set gizmo sqs config to false for consuming base64 and update the sqs processor to be roughly functional
  • Fixing lint issues
  • Add artifact configuration to the sandbox values file
  • Infra related updates
    • Remove the old python artifact service helm templates
    • update local sandbox configuration to support routing back out to local development endpoint

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
…hanges made since 161aa88a0137d73041adfa31474bd94043cc2575. remove the inputs/outputs logic from the cloud publisher on the admin side and move it to the event handler on the artifact side, remove the initialization sql bit and made the hstore thing just a migration, refactor the handler to be outside of the receiver in artifact events, add adminclient into the servicecallhandler object, set gizmo sqs config to false for consuming base64, update the sqs processor to be roughly functional

Signed-off-by: Yee Hing Tong <[email protected]>
…andbox configuration to support routing back out to local

Signed-off-by: Yee Hing Tong <[email protected]>
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f60ae81) 58.13% compared to head (f8bd008) 58.17%.

❗ Current head f8bd008 differs from pull request most recent head dc28bc4. Consider uploading reports for the commit dc28bc4 to get more accurate results

Files Patch % Lines
flytestdlib/database/db.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           artifacts    #4646      +/-   ##
=============================================
+ Coverage      58.13%   58.17%   +0.04%     
=============================================
  Files            626      626              
  Lines          53814    53761      -53     
=============================================
- Hits           31283    31278       -5     
+ Misses         20031    19981      -50     
- Partials        2500     2502       +2     
Flag Coverage Δ
unittests 58.17% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor marked this pull request as ready for review December 28, 2023 04:10
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Dec 28, 2023
@wild-endeavor
Copy link
Contributor Author

@eapolinario maybe we can talk about the go mod change. I kept running into an error with go mod tidy, ended up resolving it by setting sigs.k8s.io/controller-runtime to a real version rather than the 00001000 version or whatever. but it's replaced anyways so i feel like it shouldn't matter. not sure what i was doing wrong.

wild-endeavor and others added 5 commits December 28, 2023 19:21
@wild-endeavor wild-endeavor merged commit c06527e into artifacts Dec 29, 2023
41 of 44 checks passed
@wild-endeavor wild-endeavor deleted the artf/cleanup-post-shell branch December 29, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants