-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artf/cleanup post shell #4646
Artf/cleanup post shell #4646
Conversation
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
…hanges made since 161aa88a0137d73041adfa31474bd94043cc2575. remove the inputs/outputs logic from the cloud publisher on the admin side and move it to the event handler on the artifact side, remove the initialization sql bit and made the hstore thing just a migration, refactor the handler to be outside of the receiver in artifact events, add adminclient into the servicecallhandler object, set gizmo sqs config to false for consuming base64, update the sqs processor to be roughly functional Signed-off-by: Yee Hing Tong <[email protected]>
…andbox configuration to support routing back out to local Signed-off-by: Yee Hing Tong <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## artifacts #4646 +/- ##
=============================================
+ Coverage 58.13% 58.17% +0.04%
=============================================
Files 626 626
Lines 53814 53761 -53
=============================================
- Hits 31283 31278 -5
+ Misses 20031 19981 -50
- Partials 2500 2502 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@eapolinario maybe we can talk about the go mod change. I kept running into an error with go mod tidy, ended up resolving it by setting |
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Now that the first shell pr has been merged into master, we're doing some clean up work.