feat(propeller): Add new config to disable fallback to container task handler #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
MortalHappiness
force-pushed
the
feature/#5076-prevent-fallback-container-handler
branch
from
58a3d3a to
8d23dc9
Compare
MortalHappiness
changed the title
MortalHappiness
force-pushed
the
feature/#5076-prevent-fallback-container-handler
branch
from
8d23dc9 to
5326ad2
Compare
MortalHappiness
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5077 +/- ##
=======================================
Coverage 60.23% 60.23%
=======================================
Files 646 646
Lines 45664 45667 +3
=======================================
+ Hits 27505 27508 +3
Misses 15569 15569
Partials 2590 2590
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MortalHappiness
force-pushed
the
feature/#5076-prevent-fallback-container-handler
branch
from
5326ad2 to
b39eab9
Compare
MortalHappiness
changed the title
MortalHappiness
force-pushed
the
feature/#5076-prevent-fallback-container-handler
branch
from
b39eab9 to
2f7b1cd
Compare
dosubot
bot
added
size:L
MortalHappiness
force-pushed
the
feature/#5076-prevent-fallback-container-handler
branch
3 times, most recently
from
1c7ae32 to
864dacb
Compare
MortalHappiness
force-pushed
the
feature/#5076-prevent-fallback-container-handler
branch
2 times, most recently
from
862f846 to
92f7076
Compare
… handler Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
feature/#5076-prevent-fallback-container-handler
branch
from
92f7076 to
99538c3
Compare
|
@pingsutw Can you help me review this PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Resolves: #5076
Why are the changes needed?
If a task does not have a default plugin handler, it will fall back to the container task handler. We usually do not want this behavior and expect the task without corresponding task handlers to fail.
What changes were proposed in this pull request?
Add a new config
fallback-to-container-handlerunder thetask-pluginssection.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link