Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deprecated integrations docs to flyte #5267

Closed
wants to merge 11 commits into from

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Apr 22, 2024

What changes were proposed in this pull request?

Moves deprecated integrations docs to flyte from flytesnacks and uses rli (remoteliteralinclude) directive to include code from code files in flytesnacks repo.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Merge this PR first, then merge flyteorg/flytesnacks#1655

Docs link

TK

nikki everett added 2 commits April 22, 2024 12:10
@neverett neverett self-assigned this Apr 22, 2024
nikki everett added 4 commits April 23, 2024 10:55
@neverett neverett marked this pull request as ready for review April 23, 2024 18:52
@neverett neverett requested a review from ppiegaze as a code owner April 23, 2024 18:52
@neverett neverett changed the title [WIP] Move deprecated integrations docs to flyte Move deprecated integrations docs to flyte Apr 23, 2024
nikki everett added 5 commits April 23, 2024 15:34
@neverett
Copy link
Contributor Author

@eapolinario @cosmicBboy I'm not sure why the docs build is failing with Could not import extension sphinx_reredirects (exception: No module named 'sphinx_reredirects'). I added that module as a dependency to monodocs-environment.yaml and regenerated monodocs-environment.lock.yaml. To test, I deleted and reinstalled my local monodocs-env environment from the new lockfile and was able to successfully build docs locally. Is there anything else I need to do to get that new dependency installed in the build environment?

@neverett
Copy link
Contributor Author

Going to try closing and reopening this PR.

@neverett neverett closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant