docs: add nested_type example in data_types_and_io/structured_dataset.py
#5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin362667
changed the title
nested_type example in data_types_and_io/structured_dataset.py
neverett
previously approved these changes
Apr 23, 2024
austin362667
force-pushed
the
austin362667/sd_nested_types
branch
from
79110eb to
9f1da7e
Compare
neverett
previously approved these changes
Apr 29, 2024
pingsutw
reviewed
Apr 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5269 +/- ##
=======================================
Coverage 61.10% 61.10%
=======================================
Files 794 794
Lines 51213 51213
=======================================
Hits 31295 31295
Misses 17037 17037
Partials 2881 2881
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
austin362667
force-pushed
the
austin362667/sd_nested_types
branch
from
1e8962e to
5c3906d
Compare
Signed-off-by: Austin Liu <[email protected]> update line numbers Signed-off-by: Austin Liu <[email protected]>
austin362667
force-pushed
the
austin362667/sd_nested_types
branch
from
5c3906d to
77aa4e4
Compare
There was a problem hiding this comment.
Hi, @austin362667
Can you help add these lines to the doc?
there's a bug created by others.
https://github.com/flyteorg/flytesnacks/blob/master/examples/data_types_and_io/data_types_and_io/structured_dataset.py#L147-L149
Signed-off-by: Austin Liu <[email protected]>
Future-Outlier
approved these changes
May 9, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#4241
flyteorg/flytekit#2252
flyteorg/flytesnacks#1657
Why are the changes needed?
Add
structured_dataset_nested_typeexamples in documentation.flyteorg/flytekit#2252
What changes were proposed in this pull request?
Demonstrate how to use
nested_typesinstructured_datasetHow was this patch tested?
https://github.com/flyteorg/flytekit/pull/2252/files#diff-e78d93a6e6cd2463cd5fc51973434c29ece29d05fe6b36691d6d19860386f938
Setup process
make dev-docsScreenshots
Check all the applicable boxes
Related PRs
flyteorg/flytekit#2252
flyteorg/flytesnacks#1657
Docs link
https://flyte--5269.org.readthedocs.build/en/5269/user_guide/data_types_and_io/structureddataset.html#structured-dataset