Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced SMTP notification #5535

Merged
merged 33 commits into from
Sep 16, 2024

Using mocker 1.0.1

50ce320
Select commit
Loading
Failed to load commit list.
Merged

Introduced SMTP notification #5535

Using mocker 1.0.1
50ce320
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 16, 2024 in 1s

36.25% (+0.03%) compared to e67aae0

View this Pull Request on Codecov

36.25% (+0.03%) compared to e67aae0

Details

Codecov Report

Attention: Patch coverage is 48.36066% with 126 lines in your changes missing coverage. Please review.

Project coverage is 36.25%. Comparing base (e67aae0) to head (50ce320).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...admin/pkg/async/notifications/mocks/smtp_client.go 32.25% 83 Missing and 22 partials ⚠️
...sync/notifications/implementations/smtp_emailer.go 89.04% 5 Missing and 3 partials ⚠️
flyteadmin/pkg/server/service.go 0.00% 6 Missing ⚠️
flyteadmin/pkg/async/notifications/factory.go 37.50% 5 Missing ⚠️
flyteadmin/pkg/rpc/adminservice/base.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5535      +/-   ##
==========================================
+ Coverage   36.21%   36.25%   +0.03%     
==========================================
  Files        1303     1305       +2     
  Lines      109644   109874     +230     
==========================================
+ Hits        39710    39831     +121     
- Misses      65810    65894      +84     
- Partials     4124     4149      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov