-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributing docs #5830
Merged
Merged
Update contributing docs #5830
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dd1d27f
apply changes from @cosmicBboy flytesnacks PR https://github.com/flyt…
368d271
move docs contributing guide to new subdirectory
6255e3a
move contributing guides into separate docs
b142857
small edits
9b84928
add formatting info to docs contributing doc
ddf54a1
small edit
58755f6
Merge branch 'master' into nikki/docs/copy-contributing-updates
71196d7
Merge branch 'master' into nikki/docs/copy-contributing-updates
1983ca4
explain difference between user guide and tutorials and integrations …
a66ef95
Merge branch 'master' into nikki/docs/copy-contributing-updates
99d5b05
update redirects
5293aa0
update links
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
(contribute_docs)= | ||
|
||
# Contributing documentation | ||
|
||
```{eval-rst} | ||
.. tags:: Contribute, Basic | ||
``` | ||
|
||
Whether you're a novice or experienced software engineer, data scientist, or machine learning | ||
practitioner, we welcome your contributions to the Flyte documentation! | ||
|
||
The Flyte documentation comprises the following types: | ||
|
||
* **{ref}`User guide <userguide>` documentation:** Conceptual and procedural documentation about using Flyte features to accomplish tasks. | ||
* **{ref}`Tutorials <tutorials>`:** Longer, more advanced guides that use multiple Flyte features to solve real-world problems. Some tutorials may require extra setup, while others can only run on larger clusters. | ||
* **{ref}`Integrations examples <integrations>`:** These examples showcase how to use the Flyte plugins that integrate with the broader data and machine learning ecosystem. | ||
* **{ref}`Deployment documentation <deployment>`:** Guidance on deploying and configuring the Flyte backend. | ||
* **{doc}`API documentation <../../api/index>`:** flytekit, flytectl, and flyteidl documentation. | ||
|
||
For minor edits that don't require a local setup, you can edit the page in GitHub page to propose improvements. | ||
|
||
## Contributing to user guide and deployment documentation | ||
|
||
To update user guide or deployment documentation, edit the corresponding files in the [flyte repository](https://github.com/flyteorg/flyte/tree/master/docs/user_guide). | ||
|
||
### Code in user guide documentation | ||
|
||
If you want to include tested, runnable example code in user guide documentation, you will need to add your code to the examples directory of the [flytesnacks repository](https://github.com/flyteorg/flytesnacks). Write your code in regular Python, with regular comments. These comments **will not** be extracted from the Python file and turned into user-facing documentation. You can use the `rli` ([remoteliteralinclude](https://github.com/wpilibsuite/sphinxext-remoteliteralinclude/blob/main/README.md)) directive to include snippets of code from your example Python file. | ||
|
||
## Contributing to API documentation | ||
|
||
* **flytekit:** See the [flytekit repository](https://github.com/flyteorg/flytekit). Documentation consists of content in submodule `__init__.py` files, `rst` files, and docstrings in classes and methods. | ||
* **flytectl:** See the [flyte repository](https://github.com/flyteorg/flyte/tree/master/flytectl). Documentation consists of `rst` files in the `flytectl/docs` directory and comments in code files. | ||
* **flyteidl:** See the [flyte repository](https://github.com/flyteorg/flyte/tree/master/flyteidl). `protoc-gen-doc` is used to generate this documentation from `.proto` files. | ||
|
||
## Contributing tutorials and integrations examples | ||
|
||
Follow the steps in {ref}`Contributing tutorials or integrations examples <contribute_examples>`. | ||
|
||
## Docs formatting | ||
|
||
Our documentation contains a mix of Markdown and reStructuredText. | ||
|
||
### Markdown | ||
|
||
User guide documentation and tutorials and integrations examples uses MyST Markdown. For more information, see the [MyST syntax documentation](https://mystmd.org/guide/syntax-overview). | ||
|
||
### ReStructured text | ||
|
||
Deployment and API docs mostly use reStructured Text. For more information, see the [reStructuredText documentation](https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html). | ||
|
||
### Python objects | ||
|
||
You can cross-reference multiple Python modules, functions, classes, methods, and global data in documentations. For more information, see the [Sphinx documentation](https://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html#cross-referencing-python-objects). | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence reads oddly: "These comments will not be extracted from the Python file and turned into use-facing documentation"
The reader may be left wondering why exactly this particular fact about the comments is being called out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point -- this is to differentiate user guide examples in flytesnacks from tutorials and integrations examples in that repo, which have their comments turned into rendered docs. I can make that more explicit.