wip - Override literal in the case of attribute access of primitive values #6194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Code Review Agent Run #31d7d8Actionable Suggestions - 1
Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
flyte-bot
reviewed
Jan 27, 2025
Comment on lines
+187
to
+244
| // Check if the current value is a primitive type, and if it is convert that to a literal scalar | ||
| if _, ok := currVal.(string); ok { | ||
| return &core.Literal{ | ||
| Value: &core.Literal_Scalar{ | ||
| Scalar: &core.Scalar{ | ||
| Value: &core.Scalar_Primitive{ | ||
| Primitive: &core.Primitive{ | ||
| Value: &core.Primitive_StringValue{ | ||
| StringValue: currVal.(string), | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, nil | ||
| } else if _, ok := currVal.(int); ok { | ||
| return &core.Literal{ | ||
| Value: &core.Literal_Scalar{ | ||
| Scalar: &core.Scalar{ | ||
| Value: &core.Scalar_Primitive{ | ||
| Primitive: &core.Primitive{ | ||
| Value: &core.Primitive_Integer{ | ||
| Integer: int64(currVal.(int)), | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, nil | ||
| } else if _, ok := currVal.(float64); ok { | ||
| return &core.Literal{ | ||
| Value: &core.Literal_Scalar{ | ||
| Scalar: &core.Scalar{ | ||
| Value: &core.Scalar_Primitive{ | ||
| Primitive: &core.Primitive{ | ||
| Value: &core.Primitive_FloatValue{ | ||
| FloatValue: currVal.(float64), | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, nil | ||
| } else if _, ok := currVal.(bool); ok { | ||
| return &core.Literal{ | ||
| Value: &core.Literal_Scalar{ | ||
| Scalar: &core.Scalar{ | ||
| Value: &core.Scalar_Primitive{ | ||
| Primitive: &core.Primitive{ | ||
| Value: &core.Primitive_Boolean{ | ||
| Boolean: currVal.(bool), | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, nil | ||
| } |
There was a problem hiding this comment.
Consider extracting primitive type conversion logic
Consider extracting primitive type conversion logic into a separate helper function to improve code maintainability and reduce duplication. The current implementation has similar conversion patterns repeated for different primitive types.
Code suggestion
Check the AI-generated fix before applying
Suggested change
| // Check if the current value is a primitive type, and if it is convert that to a literal scalar | |
| if _, ok := currVal.(string); ok { | |
| return &core.Literal{ | |
| Value: &core.Literal_Scalar{ | |
| Scalar: &core.Scalar{ | |
| Value: &core.Scalar_Primitive{ | |
| Primitive: &core.Primitive{ | |
| Value: &core.Primitive_StringValue{ | |
| StringValue: currVal.(string), | |
| }, | |
| }, | |
| }, | |
| }, | |
| }, | |
| }, nil | |
| } else if _, ok := currVal.(int); ok { | |
| return &core.Literal{ | |
| Value: &core.Literal_Scalar{ | |
| Scalar: &core.Scalar{ | |
| Value: &core.Scalar_Primitive{ | |
| Primitive: &core.Primitive{ | |
| Value: &core.Primitive_Integer{ | |
| Integer: int64(currVal.(int)), | |
| }, | |
| }, | |
| }, | |
| }, | |
| }, | |
| }, nil | |
| } else if _, ok := currVal.(float64); ok { | |
| return &core.Literal{ | |
| Value: &core.Literal_Scalar{ | |
| Scalar: &core.Scalar{ | |
| Value: &core.Scalar_Primitive{ | |
| Primitive: &core.Primitive{ | |
| Value: &core.Primitive_FloatValue{ | |
| FloatValue: currVal.(float64), | |
| }, | |
| }, | |
| }, | |
| }, | |
| }, | |
| }, nil | |
| } else if _, ok := currVal.(bool); ok { | |
| return &core.Literal{ | |
| Value: &core.Literal_Scalar{ | |
| Scalar: &core.Scalar{ | |
| Value: &core.Scalar_Primitive{ | |
| Primitive: &core.Primitive{ | |
| Value: &core.Primitive_Boolean{ | |
| Boolean: currVal.(bool), | |
| }, | |
| }, | |
| }, | |
| }, | |
| }, | |
| }, nil | |
| } | |
| // Convert primitive types to literal scalar | |
| if lit, err := convertPrimitiveToLiteral(currVal); err == nil { | |
| return lit, nil | |
| } |
Code Review Run #31d7d8
Is this a valid issue, or was it incorrectly flagged by the Agent?
- it was incorrectly flagged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6194 +/- ##
==========================================
- Coverage 37.08% 35.39% -1.69%
==========================================
Files 1318 1002 -316
Lines 132707 102296 -30411
==========================================
- Hits 49208 36210 -12998
+ Misses 79244 63091 -16153
+ Partials 4255 2995 -1260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
N/A
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR enhances the attribute path resolver by adding support for handling primitive type values in binary IDL. The changes introduce automatic conversion of primitive types (string, int, float64, and boolean) into their corresponding literal scalar representations, improving the system's flexibility in attribute handling.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1