Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flyteadmin doesn't shutdown servers gracefully #6289

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lowc1012
Copy link
Contributor

Tracking issue

#6274

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 33.82%. Comparing base (588ceec) to head (a264c15).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
flyteadmin/pkg/server/service.go 0.00% 34 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6289       +/-   ##
===========================================
- Coverage   50.37%   33.82%   -16.56%     
===========================================
  Files        1170     1329      +159     
  Lines       92851   147835    +54984     
===========================================
+ Hits        46774    49999     +3225     
- Misses      41931    92994    +51063     
- Partials     4146     4842      +696     
Flag Coverage Δ
unittests-datacatalog 48.01% <ø> (-3.58%) ⬇️
unittests-flyteadmin 50.06% <0.00%> (-1.82%) ⬇️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 58.09% <ø> (-4.24%) ⬇️
unittests-flyteidl 6.78% <ø> (?)
unittests-flyteplugins 49.01% <ø> (-5.13%) ⬇️
unittests-flytepropeller 36.52% <ø> (-6.34%) ⬇️
unittests-flytestdlib 50.38% <ø> (-4.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lowc1012 lowc1012 changed the title Flyte issue 6274 fix: flyteadmin doesn't shutdown servers gracefully Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants