Skip to content

Commit

Permalink
nit
Browse files Browse the repository at this point in the history
Signed-off-by: Kevin Su <[email protected]>
  • Loading branch information
pingsutw committed Jun 4, 2024
1 parent 7584df3 commit fb03662
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def create_envd_config(image_spec: ImageSpec) -> str:
run_commands = _create_str_from_package_list(image_spec.commands)
conda_channels = _create_str_from_package_list(image_spec.conda_channels)
apt_packages = _create_str_from_package_list(image_spec.apt_packages)
env = {"PYTHONPATH": "/root", _F_IMG_ID: image_spec.image_name()}
env = {"PYTHONPATH": "/root:", _F_IMG_ID: image_spec.image_name()}

if image_spec.env:
env.update(image_spec.env)
Expand Down
6 changes: 3 additions & 3 deletions plugins/flytekit-envd/tests/test_image_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def build():
run(commands=["echo hello"])
install.python_packages(name=["pandas"])
install.apt_packages(name=["git"])
runtime.environ(env={{'PYTHONPATH': '/root', '_F_IMG_ID': '{image_name}'}}, extra_path=['/root'])
runtime.environ(env={{'PYTHONPATH': '/root:', '_F_IMG_ID': '{image_name}'}}, extra_path=['/root'])
config.pip_index(url="https://private-pip-index/simple")
install.python(version="3.8")
io.copy(source="./", target="/root")
Expand Down Expand Up @@ -88,7 +88,7 @@ def build():
run(commands=[])
install.python_packages(name=["flytekit"])
install.apt_packages(name=[])
runtime.environ(env={{'PYTHONPATH': '/root', '_F_IMG_ID': '{image_name}'}}, extra_path=['/root'])
runtime.environ(env={{'PYTHONPATH': '/root:', '_F_IMG_ID': '{image_name}'}}, extra_path=['/root'])
config.pip_index(url="https://pypi.org/simple")
install.conda(use_mamba=True)
install.conda_packages(name=["pytorch", "cpuonly"], channel=["pytorch"])
Expand Down Expand Up @@ -122,7 +122,7 @@ def build():
run(commands=[])
install.python_packages(name=["-U --pre pandas", "torch", "torchvision"])
install.apt_packages(name=[])
runtime.environ(env={{'PYTHONPATH': '/root', '_F_IMG_ID': '{image_name}'}}, extra_path=['/root'])
runtime.environ(env={{'PYTHONPATH': '/root:', '_F_IMG_ID': '{image_name}'}}, extra_path=['/root'])
config.pip_index(url="https://pypi.org/simple", extra_url="https://download.pytorch.org/whl/cpu https://pypi.anaconda.org/scientific-python-nightly-wheels/simple")
"""
)
Expand Down

0 comments on commit fb03662

Please sign in to comment.