Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fast registration removes datetime metadata from files #2332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChungYujoyce
Copy link
Contributor

Tracking issue

flyteorg/flyte#4711

What changes were proposed in this pull request?

Remove the filter function and leave it with default filter=None

How was this patch tested?

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: ChungYujoyce <[email protected]>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 5, 2024
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.52%. Comparing base (e121d35) to head (3ad7768).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2332       +/-   ##
===========================================
- Coverage   83.09%   53.52%   -29.57%     
===========================================
  Files         324      180      -144     
  Lines       24853    18132     -6721     
  Branches     3758     3546      -212     
===========================================
- Hits        20651     9706    -10945     
- Misses       3581     8000     +4419     
+ Partials      621      426      -195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! some tests are failing. mind taking a look

@wild-endeavor
Copy link
Contributor

Does this work? it still produces the same version if you register twice? when we implemented this we traced the duplicate versions to the timestamp of the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants