-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeTransformer] Support non-Any Python types as Any input in workflows #2432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
May 20, 2024 07:13
Future-Outlier
changed the title
[TypeTransformer] support input Non-Any Any Type
[WIP] [TypeTransformer] support input Non-Any Any Type
May 20, 2024
Future-Outlier
force-pushed
the
fix-any-type-input-output
branch
from
May 22, 2024 08:47
6b0f010
to
fb11101
Compare
Future-Outlier
changed the title
[WIP] [TypeTransformer] support input Non-Any Any Type
[TypeTransformer] support input Non-Any Any Type
May 22, 2024
Future-Outlier
changed the title
[TypeTransformer] support input Non-Any Any Type
[TypeTransformer] support Non-Any to Any Conversion
May 22, 2024
Future-Outlier
changed the title
[TypeTransformer] support Non-Any to Any Conversion
[TypeTransformer] Support Python non-any type as any input and output in workflow
May 22, 2024
3 tasks
Future-Outlier
changed the title
[TypeTransformer] Support Python non-any type as any input and output in workflow
[TypeTransformer] Support non-Any Python types as Any input and output in workflows
May 22, 2024
Update: I'm not sure if it's ok to support primitive types only. |
Future-Outlier
changed the title
[TypeTransformer] Support non-Any Python types as Any input and output in workflows
[TypeTransformer] Support non-Any Python types as Any output in workflows
May 24, 2024
Future-Outlier
changed the title
[TypeTransformer] Support non-Any Python types as Any output in workflows
[TypeTransformer] Support non-Any Python types as Any input in workflows
May 24, 2024
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
force-pushed
the
fix-any-type-input-output
branch
from
May 25, 2024 05:51
e4518b6
to
4733f0b
Compare
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Note: |
Signed-off-by: Future-Outlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5366
Why are the changes needed?
We want to allow the Any type to accept all kinds of inputs and outputs, not just the types we currently can't handle.
For example, workflow like this.
Note: This PR only supports
Any
in python, if we want to support java, we will need to add more code.What changes were proposed in this pull request?
Check if the literal's scalar has a primitive type.
If it does, convert it to a Python value using the corresponding type transformer.
How was this patch tested?
unit test and remote cluster
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flyteorg/flyte#5408