Prevent mutable default arguments #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2443 +/- ##
===========================================
- Coverage 89.99% 75.90% -14.09%
===========================================
Files 45 182 +137
Lines 1919 18472 +16553
Branches 0 3610 +3610
===========================================
+ Hits 1727 14022 +12295
- Misses 192 3846 +3654
- Partials 0 604 +604 ☔ View full report in Codecov by Sentry. |
cosmicBboy
previously approved these changes
May 23, 2024
|
need to fix tho |
wild-endeavor
previously approved these changes
May 24, 2024
2 tasks
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
dismissed stale reviews from wild-endeavor and cosmicBboy
via
de87986
…guments Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
commented
Jun 4, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
pingsutw
approved these changes
Jun 6, 2024
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
* Prevent mutable default arguments Signed-off-by: Eduardo Apolinario <[email protected]> * Do not lint tests Signed-off-by: Eduardo Apolinario <[email protected]> * Bump precommit hook version Signed-off-by: Eduardo Apolinario <[email protected]> * Remove default value for dictionary in Spark class Signed-off-by: Eduardo Apolinario <[email protected]> * Run precommit hook locally Signed-off-by: Eduardo Apolinario <[email protected]> * Fix lint error in openai plugin Signed-off-by: Eduardo Apolinario <[email protected]> * Handle nil databricks_conf in spark plugin Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: bugra.gedik <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Prevent mutable default arguments Signed-off-by: Eduardo Apolinario <[email protected]> * Do not lint tests Signed-off-by: Eduardo Apolinario <[email protected]> * Bump precommit hook version Signed-off-by: Eduardo Apolinario <[email protected]> * Remove default value for dictionary in Spark class Signed-off-by: Eduardo Apolinario <[email protected]> * Run precommit hook locally Signed-off-by: Eduardo Apolinario <[email protected]> * Fix lint error in openai plugin Signed-off-by: Eduardo Apolinario <[email protected]> * Handle nil databricks_conf in spark plugin Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Mutable default arguments are an anti-pattern in python. Let's catch that via a lint rule.
What changes were proposed in this pull request?
Enable https://docs.astral.sh/ruff/rules/mutable-argument-default/ in ruff.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link