Fix CI by restricting hugging face dataset version #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
pingsutw
reviewed
Jun 4, 2024
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| plugin_requires = [ | |||
| "flytekit>=1.3.0b2,<2.0.0", | |||
| "datasets>=2.4.0", | |||
| "datasets>=2.4.0,<2.19.2", | |||
There was a problem hiding this comment.
nit: I hope they will fix the bug in the next release
Suggested change
| "datasets>=2.4.0,<2.19.2", | |
| "datasets>=2.4.0,!2.19.2", | |
There was a problem hiding this comment.
nit: I hope they will fix the bug in the next release
No problem, thank you
Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]>
eapolinario
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Thank you!
I couldn't find an issue on their issue tracker.
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* init Signed-off-by: Future-Outlier <[email protected]> * Update pingsu's advice Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just saw that the datasets module had its latest release, so I guess it is the root cause of the CI failure, and it works now.
https://pypi.org/project/datasets/#history