Improve IPAConfig #183
Merged
Improve IPAConfig #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 92.99% 93.47% +0.48%
==========================================
Files 55 55
Lines 3481 3630 +149
Branches 353 376 +23
==========================================
+ Hits 3237 3393 +156
+ Misses 232 223 -9
- Partials 12 14 +2 ☔ View full report in Codecov by Sentry. |
tibuch
reviewed
Sep 24, 2024
imagejan
force-pushed
the
pydantic-questionary
branch
from
5d558b8
to
b2b1f41
Compare
This feature only works in Python 3.12+
Default to get_git_root as reference for storing relative paths. For validating user input and handling paths in the config, we consistently use absolute paths. Only for serialization, paths are converted relative to the reference directory.
imagejan
force-pushed
the
pydantic-questionary
branch
from
7128a99
to
300ddd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPAConfig(orpydantic.BaseModel) instance, usingquestionaryand validating directly withpydantic.IPAConfigmodel.