Fixes #216 - cloning disks thin relocation and storagePod location #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezr-ondrej
force-pushed
the
clone_disk_configurations
branch
2 times, most recently
from
278f92b to
2704a9d
Compare
|
This didn't work :( Screenshot: Traceback: Failed to create a compute VMware (VMware) instance molly-
stewart.toledo.satellite.lab.eng.rdu2.redhat.com:
InvalidRequest: Required property diskId is missing from data object of type PodDiskLocator while parsing serialized DataObject of type vim.storageDrs.PodSelectionSpec.DiskLocator at line 1, column 550 while parsing property "disk" of static type ArrayOfPodDiskLocator while parsing serialized DataObject of type vim.storageDrs.PodSelectionSpec.VmPodConfig at line 1, column 445 while parsing property "initialVmConfig" of static type ArrayOfVmPodConfigForPlacement while parsing serialized DataObject of type vim.storageDrs.PodSelectionSpec at line 1, column 389 while parsing property "podSelectionSpec" of static type StorageDrsPodSelectionSpec while parsing serialized DataObject of type vim.storageDrs.StoragePlacementSpec at line 1, column 283 while parsing call information for method RecommendDatastores at line 1, column 177 while parsing SOAP body at line 1, column 167 while parsing SOAP envelope at line 1, column 0 while parsing HTTP request for method recommendDatastores on object of type vim.StorageResourceManager at line 1, column 0 |
ezr-ondrej
force-pushed
the
clone_disk_configurations
branch
from
2704a9d to
387979b
Compare
|
Ok, I believe I have this figured out :) |
|
@ezr-ondrej I am on PTO tomorrow but will check on it Tuesday when I am back online. |
|
Works great @ezr-ondrej feel free to merge and we can get a new release out once #219 is merged. Image:
----------------------------------------------------------------------------------
VM creation with single HDD on Local Datastore - Passed
VM creation with added HDD on Local Datastore - Passed
VM creation with single HDD on Storage Pod - Passed
VM creation with added HDD on same Storage Pod - Passed
VM creation with added HDD on different Storage Pod - Passed |
chris1984
added
Ready for merge
and removed
Needs Testing on Foreman
Waiting on contributor
labels
|
This came out of the discussion around this #220 Merging for now since this would be out of the scope of the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216 and allows specifying the thin provisioning for cloned VMs from templates.
The main change is in the new disks being added in separate task after the machine is cloned.
The drawback is, that now it is not an atomic action, so if adding the disk fails for some reason, the machine stays in the vcenter.